Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85 added support for the
stack_
keyword. Internal adoption has revealed some bugs in the parenthesization behavior. Two examples:becomes
(invalid syntax)
becomes
(parsetree change)
This PR fixes the precedence associated with
Pexp_stack
in the extended AST for these two patterns, as well as for a number of patterns that should be uncommon (because therestack_
does not enclose an allocation, and so the code is rejected by the typechecker). We should still aim to support these cases, because:It might be worth testing
ocamlformat
's treatment ofstack_
more thoroughly in the near future, but I think it makes sense to merge this PR before doing so, since it fixes problems people have actually started to encounter.