Skip to content

Commit

Permalink
Exclude 'target' and '.DS_Store' from checkstyle coverage (typedb#390)
Browse files Browse the repository at this point in the history
## What is the goal of this PR?

We now exclude `target` and `.DS_Store` from checkstyle coverage tests.

## What are the changes implemented in this PR?

`target` is typically a generated folder (e.g. by `cargo`). `.DS_Store`
is generated by Finder on a Mac. They should be excluded from checkstyle
coverage.

NB: Fixing typedb#253 would
remove the need for this PR, but it's harder to do.
  • Loading branch information
alexjpwalker authored and James Williams committed Dec 5, 2022
1 parent 8d6c2f7 commit 8106b66
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tool/checkstyle/test-coverage.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def try_decode(s):
workspace_files, _ = tc.shell_execute([
'find', '.',
'(', '-name', '.git',
'-o', '-name', '.DS_Store',
'-o', '-name', '.idea',
'-o', '-name', '.ijwb',
'-o', '-name', '.github',
Expand All @@ -44,6 +45,7 @@ def try_decode(s):
'-o', '-name', 'VERSION',
'-o', '-name', '*.md',
'-o', '-name', 'node_modules',
'-o', '-name', 'target',
')', '-prune', '-o', '-type', 'f', '-print'
], cwd=os.getenv("BUILD_WORKSPACE_DIRECTORY"))
workspace_files = workspace_files.split()
Expand Down

0 comments on commit 8106b66

Please sign in to comment.