Make dependencies more loose #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 This PR resolves the problem of installing ecco on more modern install. (Workaround for anyone interested in using it for now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main motivation for this change was that I was failing to install this package as it depended on PyYaml 5.4.1 which has some problems - check here. But overall currently it's very hard to install this package because the dependencies are very strict (e.g. no torch 2 etc). They should be loosened up where possible.
I run tox in python 3.11 and the tests locally and with these versions' specs they seem to pass (after a minor fix in the top_k_top_p_filtering_fn). I need to see in the other Python versions with the tests from the GitHub workflows