Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup for JS, Babel, Typescript and React with code formatting apis #69

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Rollup for JS, Babel, Typescript and React with code formatting apis #69

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a452dbb
Added Webpack Dev Server to Vanilla JS
theajr Oct 21, 2019
f3a9a79
Rollup support added for Js, Babel and Typescript
theajr Oct 22, 2019
8e51919
Updated readme template
theajr Oct 22, 2019
f294695
Added React with Babel
theajr Oct 22, 2019
e61197d
Rollup support added for React Typescript
theajr Oct 23, 2019
8158bf1
removed lock file
theajr Oct 23, 2019
89ac3bb
conflict
theajr Oct 23, 2019
9a657aa
Refactor and bugfix
theajr Oct 23, 2019
2a248a4
Merge branch 'master' into feature/rollup
theajr Oct 23, 2019
e606bd1
Merge branch 'feature/rollup' of https://github.com/theajr/webpack-au…
theajr Oct 24, 2019
96b54e8
Merge branch 'master' into feature/rollup
theajr Oct 24, 2019
97164df
Latest pull and removed devServer option from webpack and added cont…
theajr Oct 24, 2019
bd151cf
Merge branch 'master' into feature/rollup
theajr Oct 26, 2019
5678390
Fixed babel issue
theajr Oct 26, 2019
e5d372a
Fixed typo and default file for rollup
theajr Oct 27, 2019
45f5e89
Fixed bugs
Nov 9, 2019
07c89a3
All cases handled
Nov 10, 2019
d0d38e2
Merge branch 'master' into feature/rollup
jakoblind Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/templates/rollup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,26 @@ export const getRollupConfig = features => {
`import commonjs from 'rollup-plugin-commonjs';`,
];
const output = [];
const plugins = ['resolve()'];
const plugins = [];
if (isBabel) {
imports.push(`import babel from "rollup-plugin-babel";`);
plugins.push(`babel({
exclude: "node_modules/**"
})`);
}
const resolveExtensions = ['.json'];
if (isReact) {
if (isTypescript) resolveExtensions.push('.ts', '.tsx');
else resolveExtensions.push('.js', '.jsx');
} else if (isTypescript) {
resolveExtensions.push('.ts');
} else {
resolveExtensions.push('.js');
}
plugins.push(`resolve({
extensions:${JSON.stringify(resolveExtensions)}
}`);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a missing ) for resolve


if (isReact) {
imports.push(
`import globals from 'rollup-plugin-node-globals';`,
Expand Down Expand Up @@ -131,12 +150,6 @@ export const getRollupConfig = features => {
} else {
plugins.push('commonjs()');
}
if (isBabel) {
imports.push(`import babel from "rollup-plugin-babel";`);
plugins.push(`babel({
exclude: "node_modules/**"
})`);
}

if (isTypescript) {
imports.push(`import typescript from 'rollup-plugin-typescript2';`);
Expand Down