Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RSS feed link to be relative to the site #25

Merged
merged 1 commit into from
Jul 28, 2015

Conversation

radumas
Copy link
Contributor

@radumas radumas commented Jul 28, 2015

I noticed on the mmenu bar that the RSS icon went to http://www.jacobtomlinson.co.uk/feed.xml so I fixed it to include the baseurl instead. I guess ideally the link's visibility could be turned on or off from the _config.yml but I think you're already working on that in #10

jacobtomlinson added a commit that referenced this pull request Jul 28, 2015
Change RSS feed link to be relative to the site
@jacobtomlinson jacobtomlinson merged commit 691024f into jacobtomlinson:gh-pages Jul 28, 2015
@jacobtomlinson
Copy link
Owner

I merged this too hastily so I've reverted it. You need to set it to be site.url followed by site.baseurl.

This is because site.url should contain your domain name e.g carte-noire.jacobtomlinson.co.uk. Then the site.baseurl should be the path at which you've installed your blog, in many cases this will be left blank if the whole site is the blog, however if you put it in a subfolder (e.g /blog) then you set this in the site.baseurl.

@jacobtomlinson
Copy link
Owner

Please fix then and resubmit your PR.

@radumas
Copy link
Contributor Author

radumas commented Jul 28, 2015

Is that specific to an RSS feed? The links above to, for example home and posts, only include the baseurl.

I had initially fixed it the way you mentioned ( {{ siteurl }}{{ baseurl }}) but then reverted it because the RSS link didn't work when served locally. Though having a working RSS link when testing a site locally seems unimportant

@jacobtomlinson
Copy link
Owner

No not specific to an RSS feed. They include baseurl but are relative to the root (e.g start with a \). That is also an option here instead of explicitly specifying site.url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants