#11 Achieve order of magnitude speedup of parser #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use faster pyparsing grammar constructs and arrangements to significantly speed up parsing - enable skipped parsing unit tests now that they are not infeasibly slow - add testing requirements to setup.py Anecdotal speed increase is from about 30 seconds to run the `test_date_values` tests down to below 3 seconds. See also #17
|
@cogat can you sanity-check these changes? They were fiddly and error-prone, but the unit tests all still pass FWIW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrangements to significantly speed up parsing
are not infeasibly slow
Anecdotal speed increase is from about 30 seconds
to run the
test_date_valuestests down to below3 seconds.
See also #17