-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data processing lifecycle of EDTFField
?
#17
Comments
Great points @jmurty I think the upshot is we need to know for an EDTFField whether it was automatically or manually populated, a bit like Occurrences for events. I envisage this as an associated checkbox called "update automatically", default True. Given that, my answers to your questions are:
How does that sound? |
- use faster pyparsing grammar constructs and arrangements to significantly speed up parsing - enable skipped parsing unit tests now that they are not infeasibly slow - add testing requirements to setup.py Anecdotal speed increase is from about 30 seconds to run the `test_date_values` tests down to below 3 seconds. See also #17
We need to give some thought to the lifecycle of data going into the
EDTFField
.Initial questions are:
when should the EDTF field be updated based on the value of the associated
natural_text_field
?natural_text_field
is cleared, presumable the EDTF and other derived field values should also be cleared?natural_text_field
value is invalid or cannot be turned into an EDTF, should the existing EDTF and other derived field values be cleared?natural_text_field
is very slow, could we somehow cache the before-and-after values and only re-parse it when it changes?can/should we permit direct interaction with the EDTFField?
natural_text_field
source field, but this is both slow and likely to lead to less precise data if there is already a known EDTF value that could be set directly (e.g. via the GLAMkit Collections API)natural_text_field
is not set, should this be reverse-generated from the EDTF value?natural_text_field
value is set subsequently. Should the EDTF value always be replaced by the parsednatural_text_field
value?lower_fuzzy_field
being set directly instead of via the EDTFField's processingThe text was updated successfully, but these errors were encountered: