Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhances USGS support and DTM provider architecture #124

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Enhances USGS support and DTM provider architecture #124

merged 3 commits into from
Jan 8, 2025

Conversation

kbrandwijk
Copy link
Collaborator

Summary:

  • Main feature: Updates USGS provider to support all USGS datasets.
  • Refactored DTM provider to use ABC so that the abstract methods can be decorated for consistent subclass implementations.
  • Introduces new metadata attributes and helper methods (contributors, base) for presentation, adjusted resolution to be more flexible to allow for multi-resolution DTM sources (like USGS now is).
  • Add UI widget to handle dictionary properties.

Notes:

  • The 'base' DTM provider property is actually WIP for some WCS based providers, it will be used in the next PR for the additional providers.
  • I actually ended up not needing the dict property yet, but it will also be used in the next PR for the additional providers.

@kbrandwijk
Enhances DTM provider architecture and USGS support
6d7b0d5 
Refactors DTM provider to use ABC for a more modular design and adds abstract methods for consistent subclass implementations. Updates USGS provider to support multiple resolutions and datasets, enhancing flexibility and coverage.

Introduces new metadata attributes and helper methods to streamline data retrieval and presentation.

Improves UI components to handle diverse data types, ensuring a more robust and intuitive user experience.
@iwatkot iwatkot self-requested a review January 8, 2025 11:01
@iwatkot iwatkot self-assigned this Jan 8, 2025
@iwatkot iwatkot added the enhancement New feature or request label Jan 8, 2025
@iwatkot
Copy link
Owner

iwatkot commented Jan 8, 2025

@kbrandwijk, hey!

Please merge the main branch with the new mypy configuration to avoid missing library stubs mypy errors.

@iwatkot
Copy link
Owner

iwatkot commented Jan 8, 2025 •
edited
Loading

@kbrandwijk, please fix the following:

maps4fs/generator/dtm/dtm.py:27:0: R0904: Too many public methods (22/20) (too-many-public-methods)

You may simply add:

# pylint: disable=R0904

Right above the class/method definition. Or lower the number of public methods.

Regards

@iwatkot iwatkot merged commit 06e1ff8 into iwatkot:main Jan 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwatkot iwatkot iwatkot approved these changes

Assignees

@iwatkot iwatkot

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrandwijk @iwatkot