-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new architecture support #2033
base: master
Are you sure you want to change the base?
Add new architecture support #2033
Conversation
looking forward to this landing and getting us one step closer to new arch support in the ecosystem! @ivpusic any chance you could merge this and get it into a new release, so that we can include it in a list of libraries supported in the new arch for react-native 74? |
@ivpusic - any chance you can land this? |
Is this PR still mergable or is it stale? |
Can this please get merged? Preventing us from updating to RN 76 |
@ivpusic Any ETA on getting this merged? |
Would love this! |
Please merge this one.. Needed |
@alanjhughes i tested your patch but its not working for me |
Please get this merged, blocked to update to RN 0.76 |
Please get this merged. Only package preventing us from updating: |
@breezertwo - in the meantime, you could consider migrating to expo-image-picker if the features there meet your requirements. at expo we opened this pr to help this library back in may but it may just be that the maintainer doesn't have time to dedicate to it anymore. |
I can confirm that I am currently short on time. @brentvatne have you done some testing on your side for this PR, or somebody else? does everything seems to be fine with the ios and android? @alanjhughes could you take a look into merge conflict? |
@ivpusic the PR is old now so I'll look at bringing it up to date |
Adds support for the new architecture with bridgeless enabled which will be the default in 0.74
Tested on
Note: On Android,onActivityResult
was not implemented in RN 0.74 RC2 on bridgeless. It will be added in RC3. I have already tested against this change and it works as expectedIssues have been resolved in RC3 and now everything works correctly