Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed camera permission on Android since it is not required #1974

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed camera permission on Android since it is not required #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4be82d5
Removed camera permission on Android since it is not required
RodolfoGS Sep 14, 2023
8f160b5
Readme updated
RodolfoGS Sep 14, 2023
c481593
Merge master
RodolfoGS Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,6 @@ Reference for more details https://github.com/ivpusic/react-native-image-crop-pi
- If you use SDK version >= 33, add following to `app/src/main/AndroidManifest.xml`
- `<uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/>`

- [Optional] If you want to use camera picker in your project, add following to `app/src/main/AndroidManifest.xml`
- `<uses-permission android:name="android.permission.CAMERA"/>`

- [Optional] If you want to use front camera, also add following to `app/src/main/
AndroidManifest.xml`
- `<uses-feature android:name="android.hardware.camera" android:required="false" />`
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/reactnative/ivpusic/imagepicker/PickerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public void openCamera(final ReadableMap options, final Promise promise) {
setConfiguration(options);
resultCollector.setup(promise, false);

permissionsCheck(activity, promise, Arrays.asList(Manifest.permission.CAMERA, Manifest.permission.WRITE_EXTERNAL_STORAGE), new Callable<Void>() {
permissionsCheck(activity, promise, Arrays.asList(Manifest.permission.WRITE_EXTERNAL_STORAGE), new Callable<Void>() {
@Override
public Void call() {
initiateCamera(activity);
Expand Down