Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss25: Add the applications page and remove broken links #26

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Conversation

andamian
Copy link
Collaborator

No description provided.

@andamian andamian mentioned this pull request May 22, 2024
@molinaro-m
Copy link
Member

Wow! v/iss25 on the test site looks great!
Why is this yet in draft?

@JeremyMcCormick
Copy link
Collaborator

Why is this yet in draft?

I believe the plan was to look at it during the hackathon and possibly get feedback from other participants.

I agree, this initial version looks very nice!

@andamian Does this remove all the dead links from the spreadsheet? (I assume so but just wanted to double check.)

@andamian
Copy link
Collaborator Author

Haven't started fixing any of the links. It's just the old content ported over md. Please double check that the issue correctly describes the scope of the problem so that we can start working on this when the time comes.

@JeremyMcCormick
Copy link
Collaborator

JeremyMcCormick commented May 22, 2024

Haven't started fixing any of the links. It's just the old content ported over md.

Okay, thanks for clarifying. We can fix those in the hackathon.

Please double check that the issue correctly describes the scope of the problem so that we can start working on this when the time comes.

The issue is basically "add applications page and fix links" so scope seems fine to me. I don't see a problem doing it in one issue/PR.

I may show this PR during my overview of contributing, as it is a nice example. Thanks for starting this!

@JeremyMcCormick JeremyMcCormick changed the title Fix the apps page Iss25: Fix the apps page May 22, 2024
@JeremyMcCormick JeremyMcCormick changed the title Iss25: Fix the apps page Iss25: Add the applications page and remove broken links May 22, 2024
@andamian andamian marked this pull request as ready for review June 12, 2024 16:22
@andamian
Copy link
Collaborator Author

@molinaro-m, @JeremyMcCormick - this looks like the last remaining PR. I've added a couple of small updates to the existing version that we've managed to test in Sydney. So even if the test site is still down, I think this could be merged into main. What do you think?

This link does not work anymore and the tool does not appear to be
publicly available anymore.
This service no longer exists.
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending a small fix I think it can be approved


### IVOA Applications Working Group

Also visit the [Applications Working Group](http://wiki.ivoa.net/twiki/bin/view/IVOA/IvoaApplications) pages on the [IVOA](/) twiki, where you can find more [VO applications](http://wiki.ivoa.net/twiki/bin/view/IVOA/IvoaApplications#Links) in different levels of maturity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IVOA wiki should be [IVOA wiki](https://wiki.ivoa.net/twiki/bin/view/IVOA) otherwise the (/) simply links back to the IVOA web site.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the link in the last md line, to me it looks fine and can be approved/merged

@JeremyMcCormick JeremyMcCormick merged commit a1f1208 into main Jul 30, 2024
1 check passed
@JeremyMcCormick JeremyMcCormick deleted the iss25 branch October 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants