-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iss25: Add the applications page and remove broken links #26
Conversation
Wow! |
I believe the plan was to look at it during the hackathon and possibly get feedback from other participants. I agree, this initial version looks very nice! @andamian Does this remove all the dead links from the spreadsheet? (I assume so but just wanted to double check.) |
Haven't started fixing any of the links. It's just the old content ported over md. Please double check that the issue correctly describes the scope of the problem so that we can start working on this when the time comes. |
Okay, thanks for clarifying. We can fix those in the hackathon.
The issue is basically "add applications page and fix links" so scope seems fine to me. I don't see a problem doing it in one issue/PR. I may show this PR during my overview of contributing, as it is a nice example. Thanks for starting this! |
@molinaro-m, @JeremyMcCormick - this looks like the last remaining PR. I've added a couple of small updates to the existing version that we've managed to test in Sydney. So even if the test site is still down, I think this could be merged into |
This link does not work anymore and the tool does not appear to be publicly available anymore.
This service no longer exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending a small fix I think it can be approved
content/astronomers/applications.md
Outdated
|
||
### IVOA Applications Working Group | ||
|
||
Also visit the [Applications Working Group](http://wiki.ivoa.net/twiki/bin/view/IVOA/IvoaApplications) pages on the [IVOA](/) twiki, where you can find more [VO applications](http://wiki.ivoa.net/twiki/bin/view/IVOA/IvoaApplications#Links) in different levels of maturity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IVOA wiki should be [IVOA wiki](https://wiki.ivoa.net/twiki/bin/view/IVOA)
otherwise the (/)
simply links back to the IVOA web site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the link in the last md line, to me it looks fine and can be approved/merged
No description provided.