Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First prototype of an improved theme/style #18

Merged
merged 5 commits into from
May 21, 2024
Merged

First prototype of an improved theme/style #18

merged 5 commits into from
May 21, 2024

Conversation

gmantele
Copy link
Member

This is kind of a draft now. There is clearly matter of improvement (especially to make it render better on small screens like smartphone). Few things can still be fixed before merging.

Fixes #6

@gmantele gmantele added the new feature New feature or request label May 20, 2024
@gmantele gmantele self-assigned this May 20, 2024
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style pointers now look OK.
I think there's still place for a better responsiveness, but that will come later on.

Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement - thanks for this update!

My requested changes would be:

  • Improve the text in the carousel. The title is too big and the author too small.
  • Make a row including the carousel and newsletter together (implicit in this suggestion is decreasing the size of the carousel which seems too big now)
  • Have the prose content on the landing page be on its own row
  • Change footer labels like "About IVOA" to grey text
  • Change the now light blue footer links to white

Following discussion, these changes could be incorporated on separate PRs if you wish.

(These are mostly just my preferences.)

Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to leave it up to you what changes to include in this PR based on my feedback (see checklist).

Additional improvements we decide to make in this area can be implemented on separate issues.

@gmantele gmantele merged commit 606107a into main May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Look and Feel
3 participants