chore: some additional logs #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
commented
Jan 8, 2024
| ) | ||
| _msg = f"Cannot fast refresh Entity Statement {iss}" | ||
| logger.warning(_msg) | ||
| # raise HttpError(_msg) |
There was a problem hiding this comment.
we should normalize this behaviour by enabling the raise of the exception.
at this moment I have disabled this due to the current not handling of this exception when the trust chain is fastly updated while some nodes are not available (that might happen in the real world)
* QRCode features (#217) * feat: changed qrcode handling * feat: copied static files from Satosa-saml2spid * feat: modified expiration time handling * fix: update test configuration * fix: remove of connection params * [Feat/retention rule] Added ttl rule for sessions (#218) * feat: added retention rule for session collection * test: added test for retention rule * Update pyeudiw/storage/mongo_storage.py Co-authored-by: Giuseppe De Marco <[email protected]> * Update pyeudiw/storage/mongo_storage.py Co-authored-by: Giuseppe De Marco <[email protected]> * Update pyeudiw/storage/base_storage.py Co-authored-by: Giuseppe De Marco <[email protected]> * chore: added config parameter --------- Co-authored-by: Giuseppe De Marco <[email protected]> * fix: error handling --------- Co-authored-by: Giuseppe De Marco <[email protected]> Co-authored-by: Ghenadie Artic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proofread of the current project with a particular attention to logging and exception handling