-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elliptic curve support #200
Merged
peppelinux
merged 22 commits into
italia:dev
from
salvatorelaiso:elliptic-curve-support
Dec 19, 2023
Merged
Elliptic curve support #200
peppelinux
merged 22 commits into
italia:dev
from
salvatorelaiso:elliptic-curve-support
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will provide a useful example on how to use the dynamic schema as per italia#102 (comment)
peppelinux
reviewed
Dec 11, 2023
peppelinux
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things to be fixed before the merge
Move the validation at the end of the initialization since some fields are transformed by the `__init__` function rather than simply loaded.
Move the validation at the end of the initialization since some fields are transformed by the `__init__` function rather than simply loaded. Update the above commit with respect to the new modifications.
Migrate tests to EC keys. Remove duplicated code.
peppelinux
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends JWEHelper class capabilities to handle encryption and decryption with the use of EC Keys.
The above functionalities are tested in the corresponding unit tests.
It also adds EC keys based integration test with new files while leaving the RSA integration test intact.
This PR provides a new JWK Schema as per TODO:
eudi-wallet-it-python/pyeudiw/oauth2/dpop/schema.py
Lines 20 to 21 in 78c00cb
The usage of this dynamic schema handling by Pydantic is documented through a simple test added in the file
test_jwk
, namedtest_dynamic_schema_validation
.The old schemas are retained for compatibility purpose until migration to this newer schemas.
Closed #102