Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added priority for formulas #957

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

KseniaGovorun
Copy link

@KseniaGovorun KseniaGovorun commented Nov 19, 2024

dev

Code reviewers

Summary of issue

Adding the ability to specify the priority of formulas in the calculator designer

Summary of change

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • PR meets all conventions

Tests for formulas

image
image
image

@KseniaGovorun KseniaGovorun self-assigned this Nov 19, 2024
@KseniaGovorun KseniaGovorun changed the title Added priority for formuls Added priority for formulas Nov 19, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (cdf3740) to head (7fcf977).
Report is 1 commits behind head on calculators-constructor.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor     #957      +/-   ##
===========================================================
+ Coverage                    89.10%   89.14%   +0.03%     
===========================================================
  Files                           68       68              
  Lines                         1056     1059       +3     
===========================================================
+ Hits                           941      944       +3     
  Misses                         115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVajnagi DanielVajnagi self-assigned this Jan 10, 2025
@@ -11,6 +11,7 @@ def index

def show
@calculator = resource
@formulas = @calculator.formulas.ordered_by_priority
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а навіщо ця змінна?

@DanielVajnagi DanielVajnagi merged commit e558ac1 into calculators-constructor Jan 17, 2025
7 checks passed
@DanielVajnagi DanielVajnagi deleted the add-priority-formuls branch January 17, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants