Make navigation for challenge slick carousel and corresponding test #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.slickCardsNames = page.locator("div.slick-slide div.name"); | ||
| this.slickDots = page.locator("ul.slick-dots li"); | ||
| this.slickRightArrow = page.locator("div.challenge-day-block span[aria-label='arrow-right']:nth-child(2) svg"); | ||
|
|
There was a problem hiding this comment.
Invalid locator nth-child(2)
DO not use hardcode.
Please update
There was a problem hiding this comment.
$$("span.arrows-next svg")
| @@ -15,6 +23,37 @@ class ChallengeInfoPage extends BasePage { | |||
| this.challengeTasksNames = page.locator("td:nth-child(2)"); | |||
There was a problem hiding this comment.
Invalid locator nth-child(2)
Please update
There was a problem hiding this comment.
$$("td.ant-table-cell > a.table-name[href*='task']")
There was a problem hiding this comment.
$x("//a[contains(text(),'Task_second')]")
|
|
||
| class ChallengeInfoPage extends BasePage { | ||
| constructor(page) { | ||
| super(page); | ||
| this.viewChallengeButton = page.getByRole("button", { name: "Переглянути челендж" }); |
There was a problem hiding this comment.
Use const for "Переглянути челендж"
| @@ -15,10 +15,6 @@ let apiservice, challengespage, challengeinfopage,taskspage, addchallengepage, a | |||
| apiservice = new ApiService(page); | |||
| challengespage = new ChallengesPage(page); | |||
| await apiservice.apiLoginAs('admin'); | |||
There was a problem hiding this comment.
Use Const for "admin"
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the ChallengeInfoPage and related files. The changes are focused on creating navigation to view the challenge's task on the view page, respective locators, and code formatting in basepage.js.
Changes:
New Feature:
Created a method for navigation to viewChallenge.
Added slick carousel locators.
Implemented a task presence verification method in the carousel.
Created a test to navigate the challenge task carousel.
Code Formatting:
Improved code formatting in basepage.js.
Files Modified:
src/test/playwright/PO/ChallengeInfoPage.js
Added new methods for navigation and task verification.
Modified existing methods for better readability.
src/test/playwright/PO/basepage.js
Improved code formatting.
Updated method names for clarity.
src/test/playwright/tests/challengesManipulation-test.spec.js
Added a test to verify navigation through challenge's existing tasks.
Testing:
Tested the new navigation features locally.
Verified that existing test cases related to challenge manipulation are still valid.