Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: drop Python 3.7 support #974

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

RaitoBezarius
Copy link
Contributor

This removes any Python 3.7 support and bumps it to 3.8 minimum as 3.7 is EOL.

As asked in #973.

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

...

Why is this necessary?

...

This removes any Python 3.7 support and bumps it to 3.8 minimum as 3.7 is EOL.
@ix5
Copy link
Member

ix5 commented Oct 31, 2023

For posterity, you should mention the reason for bumping the Python version: werkzeug version 2.3.0 and later drop support for Python 3.7 (see changelog)

We're not dropping that version because of support EOL but because your other PR requires it.

@RaitoBezarius
Copy link
Contributor Author

For posterity, you should mention the reason for bumping the Python version: werkzeug version 2.3.0 and later drop support for Python 3.7 (see changelog)

We're not dropping that version because of support EOL but because your other PR requires it.

I mean, the root cause is 3.7 has reached EOL in support and security, everyone is dropping it for that reason. The other PR, at its root reason for why it exists, is because 3.7 has been removed.

@jelmer jelmer merged commit a5514d7 into isso-comments:master Oct 31, 2023
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants