Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker, ci: Make e2e tests less flaky #1024

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 3, 2024

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

  • Check whether the comment really got created and otherwise fail faster in the integration test before PUT request
  • Improve a few documentation comments

Why is this necessary?

End-to-end tests have been flaky when run in the dockerized environment. This seems to fix it locally for me, using the following steps:

make docker
docker compose up -d
make docker-js-integration

And improve a few documentation comments
@ix5 ix5 added bug testing/ci Test coverage & GitHub actions etc. labels May 3, 2024
@ix5 ix5 added this to the 0.14 milestone May 3, 2024
@ix5 ix5 merged commit 98333e7 into isso-comments:master May 3, 2024
17 checks passed
@ix5 ix5 deleted the flaky-tests branch May 3, 2024 11:42
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testing/ci Test coverage & GitHub actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant