Skip to content

Commit

Permalink
Merge branch 'main' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
kellyguo11 authored Jan 13, 2025
2 parents bb167d5 + 9ab52d4 commit 9ea8b28
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ repos:
- id: codespell
additional_dependencies:
- tomli
exclude: "CONTRIBUTORS.md"
# FIXME: Figure out why this is getting stuck under VPN.
# - repo: https://github.com/RobertCraigie/pyright-python
# rev: v1.1.315
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Guidelines for modifications:
* Lionel Gulich
* Louis Le Lay
* Lorenz Wellhausen
* Manuel Schweiger
* Masoud Moghani
* Michael Gussert
* Michael Noseworthy
Expand Down
22 changes: 22 additions & 0 deletions source/extensions/omni.isaac.lab/test/utils/test_configclass.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,16 @@ class BasicDemoTorchCfg:
some_tensor: torch.Tensor = torch.Tensor([1, 2, 3])


@configclass
class BasicActuatorCfg:
"""Dummy configuration class for ActuatorBase config."""

joint_names_expr: list[str] = ["some_string"]
joint_parameter_lookup: list[list[float]] = [[1, 2, 3], [4, 5, 6]]
stiffness: float = 1.0
damping: float = 2.0


"""
Dummy configuration to check type annotations ordering.
"""
Expand Down Expand Up @@ -530,6 +540,18 @@ def test_dict_conversion(self):
self.assertEqual(torch_cfg_dict["some_number"], 0)
self.assertTrue(torch.all(torch_cfg_dict["some_tensor"] == torch.tensor([1, 2, 3])))

def test_actuator_cfg_dict_conversion(self):
"""Test dict conversion of ActuatorConfig."""
# create a basic RemotizedPDActuator config
actuator_cfg = BasicActuatorCfg()
# return writable attributes of config object
actuator_cfg_dict_attr = actuator_cfg.__dict__
# check if __dict__ attribute of config is not empty
self.assertTrue(len(actuator_cfg_dict_attr) > 0)
# class_to_dict utility function should return a primitive dictionary
actuator_cfg_dict = class_to_dict(actuator_cfg)
self.assertTrue(isinstance(actuator_cfg_dict, dict))

def test_dict_conversion_order(self):
"""Tests that order is conserved when converting to dictionary."""
true_outer_order = ["device_id", "env", "robot_default_state", "list_config"]
Expand Down

0 comments on commit 9ea8b28

Please sign in to comment.