Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TKW] Fixes for @conditional and paged attention #416

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Hardcode84
Copy link
Contributor

  • Fix proxy.create_arg as sympy.StrictlyLessThan and friends are not subclass of sympy.Expr.
  • It is now possible to directly use sympy expressions in @conditional arg.
  • Fix DCE to not remove ops if they contain nested ops with side-effects (e.g. writes inside conditional).
  • Update get_users/get_inputs/node_args ops to properly handle vars captured through placeholders.
  • Update CustomOp.erase to cleanup dead captures when deleting placeholders.
  • Update paged attention template.

Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Signed-off-by: Ivan Butygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant