Adds support for forecast reference metadata in CF checks. #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates cfutil's feature detection to ignore variables used to declare forecast metadata. Specifically, variables with standard names 'forecast_period' and 'forecast_reference_time' are used in conjunction with 'time' to indicate to dataset consumers the appropriate model initialization time, forecast hour, and valid time. This is useful for datasets that aggregate multiple forecast runs, such as FMRC.
benjwadams
requested changes
Mar 24, 2020
This commit incorporates the requested changes by the reviewer. - Using a set in lieu of a list for simple membership checking - Using unittest API for assertions.
benjwadams
reviewed
Mar 25, 2020
| 'forecast_period', | ||
| 'forecast_reference_time', | ||
| ] | ||
| } | ||
| forecast_metadata_variables = [] |
There was a problem hiding this comment.
I actually meant forecast_metadata_variables for the list -> set conversion, apologies if this wasn't explicit. This likely to be fairly minor, so I'll just keep as is and merge, possibly revisiting this for #727 and other similar places in code which use lists.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates cfutil's feature detection to ignore variables used
to declare forecast metadata. Specifically, variables with standard
names
forecast_periodandforecast_reference_timeare used inconjunction with
timeto indicate to dataset consumers the appropriatemodel initialization time, forecast hour, and valid time. This is
useful for datasets that aggregate multiple forecast runs, such as FMRC.