Accept ddeb from remote repositories when using "update" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to dh to easily rebuild autotools files.
To be able to build packages for the tests, use the host architecture (to avoid requiring a cross-compiler).
Using the non-existing priority 'superfluous' causes warning messages.
To test the handling of upstream tarballs, switch from source format 1.0 to either 3.0 (quilt) or 3.0 (native).
Use the common naming schema $source_$version_$arch.changes for the name of the .changes files for testing.
Closes: #857302 Signed-off-by: Benjamin Drung <[email protected]>
Compiling reprepro produces this warning: ``` signature.c: In function ‘signature_getpassphrase’: signature.c:63:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(fd, p, strlen(p)); ^~~~~~~~~~~~~~~~~~~~~~~ signature.c:64:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(fd, "\n", 1); ^~~~~~~~~~~~~~~~~~ ```
The error message in guess_component misses a leading quotation mark, for example: Could not find 'main' in components of 'bionic': contrib'
There are multiple places where new cursors are generated. Remove duplicate code by introducing the newcursor() function.
cursor_nexttempdata has an additional len_p output parameter (compared to cursor_nexttemp). Make the len_p output parameter optional and replace cursor_nexttemp by cursor_nexttempdata. Thus cursor_nexttemp(...) becomes cursor_nexttempdata(..., NULL).
The cursor_nextpair() function has a parse_pair() function for evaluating the returned database output. Introduce a similar parse_data() function for the cursor_nexttempdata() function.
Move cursor struct upwards to have the struct definition in one block.
Rename table_newduplicatecursor to table_newduplicatepairedcursor to make use this name for a data cursor.
The functions cursor_nexttempdata() and cursor_nextpair() share a similar logic. Thus combine the duplicate code in cursor_next(). cursor_nexttempdata() set always DB_NEXT as cursor flag instead of using the cursor->flags value. All users of cursor_nexttempdata() call table_newglobalcursor() [1] beforehand which sets cursor->flags = DB_NEXT. [1] Capsulated dependencies: cursor_nexttempdata -> package_next -> package_openiterator -> table_newglobalcursor
The word 'todo' is used for marking todo items for the programmer. Thus use 'remaining' instead of 'todo' as variable name.
If no package version is specfied, use the latest version.
The multi version support will require splitting the name and version in multiple places. Thus moved the code in a splitnameandversion() function.
Use variable 'result' only for the final returned result.
The DB_NODUPDATA flag may only be specified if the underlying database has been configured to support sorted duplicates. Thus do not set the DB_NODUPDATA flag when the database does not support duplicates. To avoid querying the flags on each call, save the flags when opening the table.
DB_DUPSORT allows duplicate keys in the database, but not duplicate key/value pairs. Only if the duplicate data items are unsorted, applications may store identical duplicate data items. Since the references.db stores a the filekey mapping to the codename|component|architecture triplet, there might be identical duplicates, when upstream tarballs are references by multiple version. Therefore switch references.db from DB_DUPSORT to DB_DUP. closes bug ionos-cloud#9
Closes: #570623 Signed-off-by: Benjamin Drung <[email protected]>
Limit the number of versions of a package per distribution, architecture, component, and type. The limit must be a number. If the number is positive, all old package version that exceed these limit will be removed when a new package version is added. If the number is zero or negative, all package version will be kept. By default only one package version will be kept.
Signed-off-by: Benjamin Drung <[email protected]>
When opening multiple databases in parallel (needed for the move command or the archive option), the databases needs to be configured with locking. Thus an database environment is needed. Open and close the database environment when getting/releasing the database lock. Without proper locking, the database might become corrupt: BDB0689 db/packages.db page 6387 is on free list with type 5 BDB0061 PANIC: Invalid argument Internal error of the underlying BerkeleyDB database: Within packages.db subtable jessie-proposed|main|amd64 at put(uniq): BDB0087 DB_RUNRECOVERY: Fatal error, run database recovery BDB0060 PANIC: fatal region error detected; run recovery db_close(packages.db, jessie-proposed|main|amd64): BDB0087 DB_RUNRECOVERY: Fatal error, run database recovery There have been errors!
The move command will need to open two tables at the same time (the source table and the destination table). Thus keep track of all opened tables.
The move commands needs access to the from target to remove the packages after adding them to the destination target.
Add the commands move, movesrc, movematched, movefilter.
Add test cases for the move, movesrc, movematched, movefilter commands. Signed-off-by: Benjamin Drung <[email protected]>
Closes: #730572 LP: #799889
Signed-off-by: Benjamin Drung <[email protected]>
Signed-off-by: Benjamin Drung <[email protected]>
|
Can you add a test case for that? |
|
I am not very familiar with your test framework. Can you tell me:
|
|
Since I couldn't find |
bdrung
force-pushed
the
multiple-versions-debian
branch
from
630bb1e to
3afde91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an assert error when trying to mirror a repo with ddeb (
assert ("Unexpected package type" == NULL);), because we do not handle ddeb on update. Correct that.