-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement setting mtu for virtio network device #42
Conversation
7b6b2e7
to
3c60c05
Compare
3c60c05
to
9232d60
Compare
324e238
to
4b5f506
Compare
We should not default to 1500 here. If a user has different requirements and those are already part of his preconfigured template, we're actively breaking stuff. So i argue if it's not explicitly set in the ProxmoxMachine CR, we should keep existing behaviour and not care about it. |
4b5f506
to
089d4a8
Compare
089d4a8
to
3fd27ea
Compare
As requested I removed the default MTU and applied the other suggestions, it should have the original behavior now if no MTU is set |
Sorry for the delay, I will test this and get back to you. |
have you executed it's failing in my machine |
Yes, it is working on my machine (and it is clearly also working in the Github workflow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for your contribution
For some scenarios it is required to set the MTU of the proxmox VM network interface, especially when running behind a VPN.
This adds a
MTU
field to theNetworkDevice
struct of theProxmoxMachine
CRD.See https://git.proxmox.com/?p=qemu-server.git;a=commit;h=61a14cde8d568e552d3deaab2da76b479b8aca7b
Sets the MTU value of a network machine network device: