Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update troubleshooting + quickstart docs to aid with capi incompatibilities #32

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

pborn-ionos
Copy link
Contributor

No description provided.

@pborn-ionos pborn-ionos requested a review from 65278 December 14, 2023 13:10
@@ -101,7 +101,7 @@ the `EXP_CLUSTER_RESOURCE_SET` is required if you want to deploy CNI using clust

Once you have access to a management cluster, you can initialize Cluster API with the following:
```
clusterctl init --infrastructure proxmox --ipam in-cluster
clusterctl init --infrastructure proxmox --ipam in-cluster --core cluster-api:v1.5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avorima
Do you agree with pinning the capi version in the quick-start docs?
while our compatibility versions matrix mentions that v1.6 not yet supported?
https://github.com/ionos-cloud/cluster-api-provider-proxmox/tree/main?tab=readme-ov-file#compatibility-with-cluster-api-and-kubernetes-versions

In my point of view we should plan the support for v1.6 very soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, you can remove it when v1.6 support gets released. But as it is now, it's just a pain point for the end-user, having to figure out why it's not working as described. Especially when the errors you'll encounter tell you literally nothing about the incompatibility issue itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @avorima feedback.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since those commands are meant to be copied into a terminal.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then

@pborn-ionos pborn-ionos enabled auto-merge (squash) December 14, 2023 15:05
@pborn-ionos pborn-ionos force-pushed the docs/capi-incompatibility branch from e9e0fcc to 35737e5 Compare December 14, 2023 15:06
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pborn-ionos pborn-ionos merged commit e0f76b5 into main Dec 14, 2023
9 checks passed
@pborn-ionos pborn-ionos deleted the docs/capi-incompatibility branch December 14, 2023 15:08
65278 pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants