mockery: don't use boilerplate #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikkyk
requested review from
65278,
avorima,
lubedacht,
pborn-ionos and
mcbenjemaa
as code owners
wikkyk
force-pushed
the
mockery-no-boilerplate
branch
from
3ba7b58 to
964cb77
Compare
wikkyk
added
kind/bug
|
Merged
|
approval in #236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#234
Description of changes:
We decided against forcing one boilerplate to keep the copyright lines correct and because it's questionable whether generated files are subject to copyright.
However, we forgot to actually remove the boilerplate file from mockery config.
Testing performed:
make mockgenno longer fails.