General jumbo frame support/Network Refactor #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65278
requested review from
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
wikkyk
reviewed
Apr 8, 2024
wikkyk
reviewed
Apr 8, 2024
65278
force-pushed
the
jumbo_frame_support
branch
from
23bd877 to
080500a
Compare
65278
force-pushed
the
jumbo_frame_support
branch
from
080500a to
7a75234
Compare
wikkyk
previously approved these changes
Apr 10, 2024
wikkyk
reviewed
Apr 10, 2024
wikkyk
previously approved these changes
Apr 10, 2024
|
e2e passed so it's ok to skip further e2e if the only remaining changes are documentation. |
65278
force-pushed
the
jumbo_frame_support
branch
from
ad338e5 to
4e3f580
Compare
wikkyk
force-pushed
the
jumbo_frame_support
branch
from
a38a681 to
218582f
Compare
wikkyk
force-pushed
the
jumbo_frame_support
branch
from
218582f to
bea5161
Compare
wikkyk
force-pushed
the
jumbo_frame_support
branch
from
bea5161 to
d6641f2
Compare
wikkyk
force-pushed
the
jumbo_frame_support
branch
from
ca5c489 to
3d99072
Compare
|
checks and e2e passed, merging |
wikkyk
approved these changes
Apr 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We have jumbo frame support via virtio/proxmox, but no support for other device types like e1000e (etc.pp.) or software defined networking.
This PR adds general case jumbo frame support via netplan. To achieve this, I've refactored the networking code a little to unify software defined network devices with additional network devices.
While doing this, I removed the limitation of mutually exclusive DHCP and static IP. It's nonsensical and not in netplan.
I also gave all routes a metric and made the metric of default network 100 and other network devices 200. This is still buggy, but less buggy (and dangerous) than having all interfaces add default routes with a metric of 0. This only worked because netplan applies rules in order and was subject to breaking any time.
In a nutshell, this part of netplan https://netplan.readthedocs.io/en/stable/netplan-yaml/#properties-for-all-device-types is now unified in our API and our templating, making the adding of more features much easier. The end goal is to unify AdditionalNetworkDevices with DefaultNetworkDevice, but that's an API breaking change, so I plan on doing that in v1alpha2.
I've also fixed a couple of bugs on the way.
Testing performed:
Testing is still WIP