cloudinit: fix multiple vrf device templating #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65278
requested review from
avorima,
lubedacht,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
|
Rebase and merge |
mcbenjemaa
approved these changes
Apr 2, 2024
65278
force-pushed
the
fix_vrf_templating_multiple_devices
branch
from
c1ecd8b to
b0e553d
Compare
|
65278
force-pushed
the
fix_vrf_templating_multiple_devices
branch
from
b0e553d to
fac5f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This very little templating error made it into production. It creates the same yaml key multiple times, which makes the last VRF device win in cloudinit.
Testing performed:
I've added testcases for multiple vrfs, so we don't get any repeats.