feat: support for externally managed control plane

Signed-off-by: Dario Tranchitella <[email protected]>
ionos-cloud · Jul 1, 2024 · f40f2f9 · f40f2f9
1 parent 1cfdf0b
commit f40f2f9
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 2 deletions.
diff --git a/api/v1alpha1/conditions_consts.go b/api/v1alpha1/conditions_consts.go
@@ -78,6 +78,9 @@ const (
 
 	// UnknownReason (Severity=Warning) documents the ProxmoxVM Unknown.
 	UnknownReason = "Unknown"
+
+	// MissingControlPlaneEndpointReason (Severity=Warning) documents the missing Control Plane endpoint when Cluster is backed by an externally managed Control Plane.
+	MissingControlPlaneEndpointReason = "MissingControlPlaneEndpoint"
 )
 
 const (

diff --git a/api/v1alpha1/proxmoxcluster_types.go b/api/v1alpha1/proxmoxcluster_types.go
@@ -40,6 +40,10 @@ type ProxmoxClusterSpec struct {
 	// +kubebuilder:validation:XValidation:rule="self.port > 0 && self.port < 65536",message="port must be within 1-65535"
 	ControlPlaneEndpoint *clusterv1.APIEndpoint `json:"controlPlaneEndpoint"`
 
+	// ExternalManagedControlPlane can be enabled to allow externally managed Control Planes to patch the
+	// Proxmox cluster with the Load Balancer IP provided by Control Plane provider.
+	ExternalManagedControlPlane bool `json:"externalManagedControlPlane,omitempty"`
+
 	// AllowedNodes specifies all Proxmox nodes which will be considered
 	// for operations. This implies that VMs can be cloned on different nodes from
 	// the node which holds the VM template.

diff --git a/config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclusters.yaml b/config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclusters.yaml
@@ -587,6 +587,11 @@ spec:
                   type: string
                 minItems: 1
                 type: array
+              externalManagedControlPlane:
+                description: ExternalManagedControlPlane can be enabled to allow externally
+                  managed Control Planes to patch the Proxmox cluster with the Load
+                  Balancer IP provided by Control Plane provider.
+                type: boolean
               ipv4Config:
                 description: IPv4Config contains information about available IPV4
                   address pools and the gateway. This can be combined with ipv6Config

diff --git a/config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclustertemplates.yaml b/config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclustertemplates.yaml
@@ -637,6 +637,12 @@ spec:
                           type: string
                         minItems: 1
                         type: array
+                      externalManagedControlPlane:
+                        description: ExternalManagedControlPlane can be enabled to
+                          allow externally managed Control Planes to patch the Proxmox
+                          cluster with the Load Balancer IP provided by Control Plane
+                          provider.
+                        type: boolean
                       ipv4Config:
                         description: IPv4Config contains information about available
                           IPV4 address pools and the gateway. This can be combined

diff --git a/internal/controller/proxmoxcluster_controller.go b/internal/controller/proxmoxcluster_controller.go
@@ -168,6 +168,23 @@ func (r *ProxmoxClusterReconciler) reconcileNormal(ctx context.Context, clusterS
 	// If the ProxmoxCluster doesn't have our finalizer, add it.
 	ctrlutil.AddFinalizer(clusterScope.ProxmoxCluster, infrav1alpha1.ClusterFinalizer)
 
+	if clusterScope.ProxmoxCluster.Spec.ExternalManagedControlPlane {
+		switch {
+		case clusterScope.ProxmoxCluster.Spec.ControlPlaneEndpoint.Host == "":
+			clusterScope.Logger.Info("ProxmoxCluster is not ready, missing or waiting for a ControlPlaneEndpoint host")
+
+			conditions.MarkFalse(clusterScope.ProxmoxCluster, infrav1alpha1.ProxmoxClusterReady, infrav1alpha1.MissingControlPlaneEndpointReason, clusterv1.ConditionSeverityWarning, "The ProxmoxCluster is missing or waiting for a ControlPlaneEndpoint host")
+
+			return ctrl.Result{Requeue: true}, nil
+		case clusterScope.ProxmoxCluster.Spec.ControlPlaneEndpoint.Port == 0:
+			clusterScope.Logger.Info("ProxmoxCluster is not ready, missing or waiting for a ControlPlaneEndpoint port")
+
+			conditions.MarkFalse(clusterScope.ProxmoxCluster, infrav1alpha1.ProxmoxClusterReady, infrav1alpha1.MissingControlPlaneEndpointReason, clusterv1.ConditionSeverityWarning, "The ProxmoxCluster is missing or waiting for a ControlPlaneEndpoint port")
+
+			return ctrl.Result{Requeue: true}, nil
+		}
+	}
+
 	res, err := r.reconcileIPAM(ctx, clusterScope)
 	if err != nil {
 		return ctrl.Result{}, err

diff --git a/internal/webhook/proxmoxcluster_webhook.go b/internal/webhook/proxmoxcluster_webhook.go
@@ -93,11 +93,15 @@ func (*ProxmoxCluster) ValidateUpdate(_ context.Context, _ runtime.Object, newOb
 }
 
 func validateControlPlaneEndpoint(cluster *infrav1.ProxmoxCluster) error {
-	ep := cluster.Spec.ControlPlaneEndpoint
+	// Skipping the validation of the Control Plane endpoint in case of externally managed Control Plane:
+	// the Cluster API Control Plane provider will eventually provide the LB.
+	if cluster.Spec.ExternalManagedControlPlane {
+		return nil
+	}
 
 	gk, name := cluster.GroupVersionKind().GroupKind(), cluster.GetName()
 
-	endpoint := ep.Host
+	endpoint := cluster.Spec.ControlPlaneEndpoint.Host
 
 	addr, err := netip.ParseAddr(endpoint)