Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): update focus utility to add focus states without keydown #30116

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brandyscarney
Copy link
Member

Issue number: internal


What is the current behavior?

When using an external keyboard and tabbing on an iPad, the focus state is not visible until the Shift key is pressed. This happens because the iPad does not fire the keydown event when pressing Tab.

What is the new behavior?

  • Removes the focus-visible utility's dependency on the keydown event, enabling it to correctly manage focus without relying on the event.
  • Adds a split pane test to the Ionic Angular test app.
  • Updates the test app paths to allow access to standalone tests running within the app.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.4.2-dev.11736277041.14f34ba1

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 7:32pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant