-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): added snapBreakpoints to sheet modals #30097
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm new to Ionic and I'm excited to see this closing a much needed 3 year old issue. Happy to be here just in time! 🥳 Looking forward to implementing these awesome UX patterns https://sarunw.com/posts/bottom-sheet-in-ios-15-with-uisheetpresentationcontroller/ |
@kumibrr Thank you for submitting this PR! Could you explain why a new array, |
@thetaPC Thank you for reviewing and asking! There's two main reasons I made a new array, the first is to avoid breaking changes with any current setup. ScreenRecording_01-09-2025.23-24-59_1.MP4Having a separate array enables developers to have more control in which breakpoints they want to enable scrolling. |
@kumibrr That makes sense to me. Could you try a video that showcases your proposed behavior? Or provide steps on how I can view it on my end? It seems that the one you sent in the last comment is not rendering. |
@thetaPC Sure, sorry about that. If videos do not work, you can try the proposed behavior in the following link, then clicking on "Present Sheet Modal (snapBreakpoints)", it has Screen.Recording.2025-01-10.at.09.29.11.mp4Screen.Recording.2025-01-10.at.09.26.56.mp4 |
Issue number: resolves #24631
What is the current behavior?
Sheet modals do not allow content scroll unless it's breakpoint is 1.
What is the new behavior?
Sheet modals now have an additional property
snapBreakpoints
similar tobreakpoints
which allows the developer to specify at which breakpoint the content of the modal should be scrollable.Does this introduce a breaking change?
Other information
Screen.Recording.2024-12-23.at.00.41.19.mov