Planet fix export #1372
Merged
Planet fix export #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit f776101 the request was not passed as first argument to `render`. Traceback in sentry was: ``` TypeError: join() argument must be str, bytes, or os.PathLike object, not 'dict' File "django/core/handlers/exception.py", line 55, in inner response = get_response(request) File "django/core/handlers/base.py", line 197, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "inyoka/planet/views.py", line 191, in export response = render('planet/%s.xml' % export_type, {'blogs': blogs}, File "django/shortcuts.py", line 24, in render content = loader.render_to_string(template_name, context, request, using=using) File "django/template/loader.py", line 61, in render_to_string template = get_template(template_name, using=using) File "django/template/loader.py", line 15, in get_template return engine.get_template(template_name) File "django/template/backends/django.py", line 33, in get_template return Template(self.engine.get_template(template_name), self) File "django/template/engine.py", line 175, in get_template template, origin = self.find_template(template_name) File "django/template/engine.py", line 157, in find_template template = loader.get_template(name, skip=skip) File "django/template/loaders/cached.py", line 57, in get_template template = super().get_template(template_name, skip) File "django/template/loaders/base.py", line 17, in get_template for origin in self.get_template_sources(template_name): File "django/template/loaders/cached.py", line 70, in get_template_sources yield from loader.get_template_sources(template_name) File "django/template/loaders/filesystem.py", line 35, in get_template_sources name = safe_join(template_dir, template_name) File "django/utils/_os.py", line 17, in safe_join final_path = abspath(join(base, *paths)) File "<frozen posixpath>", line 90, in join File "<frozen genericpath>", line 164, in _check_arg_types ```
Before, it would raise an `AssertionError` and a server error.
chris34
force-pushed
the
planet-fix-export
branch
from
796bddf to
9418c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages