-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config for the format command #709
feat: add config for the format command #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor nit
@spydon do you already have plans when this is released? |
We're trying to land #702 and then do a release. Currently I'm a bit sceptical of those priority groups, I'd rather just have a name for the second priority group and not have the first one at all, and then have the argument name based on that. But we haven't been able to come up with a good name yet, maybe you'd have some suggestion if you had a look? :) |
@spydon I don't think I know what's going on there, but I can try to get into it. |
Description
Added a configuration for the
melos format
command to managelineLength
andsetExitIfChanged
using the config.CLI input will overwrite the config values, but if config states
true
forsetExitIfChanged
it cannot be overwritten b/c--set-exit-if-changed
is not negatable.Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore