Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spelling error #1560

Merged
merged 4 commits into from
Oct 22, 2024
Merged

fix: spelling error #1560

merged 4 commits into from
Oct 22, 2024

Conversation

saifeiLee
Copy link
Contributor

Description

FIx some spelling error.

Motivation and Context

Word spelling errors make people confuse.

How Has This Been Tested?

npm run test result passed.

Types of changes

  • [x ] Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's remove the script and merge it :)

Comment on lines 47 to 58
},
{
"name": "Debug Current TS file",
"type": "node",
"request": "launch",
"runtimeExecutable": "node",
"runtimeArgs": [
"--nolazy", "-r", "ts-node/register/transpile-only"
],
"program": "${file}",
"cwd": "${workspaceFolder}",
"internalConsoleOptions": "openOnSessionStart",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of the scope of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of the scope of this PR

Should I revert this commit and update this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or simply add a commit removing the changes at launch.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. :)

src/planning/planner.ts Show resolved Hide resolved
@notaphplover notaphplover merged commit db2ca06 into inversify:master Oct 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants