fix: before_first_request deprecation #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
force-pushed
the
add-init-function
branch
2 times, most recently
from
5f01692 to
1b7cd2e
Compare
utnapischtim
force-pushed
the
add-init-function
branch
2 times, most recently
from
ed0d41c to
d00c7d9
Compare
utnapischtim
force-pushed
the
add-init-function
branch
from
d6d795a to
836800e
Compare
* record_once is not deprecated but since the before_(app)_first_request decorators are deprecated this has been moved also to the new invenio-base entrypoints * the blueprint_ui_init and blueprint_api_init have been removed, because they are only used as the blueprints to run record_once
* breadcrumbs has been removed since longer in invenio. now they are also removed from this package
* this refactoring uses the newly introduced global menu from invenio-theme. * this change is the implementation of the before_(app_)first_request deprecation fix.
* pytest-black seems out of support. the last commit was from 2020-10-05. Further pytest-black uses a out of date method which mentions pytest>=7.0 with a DeprecationWarning. The simplest solution is to use pytest-black-ng which fixes this situation.
utnapischtim
force-pushed
the
add-init-function
branch
from
8d124e7 to
834236d
Compare
* the problem is that the normal app creation process is not used. this custom app creation process needs a little bit love to work with the changes. * since the menu is created in Menu InvenioTheme is not necessary anymore. * the finalize_app call needs the app_context * NOTE: this has to be refactored!!
kpsherva
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependent on invenio-accounts