Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pry and pry-byebug with debug in development dependencies #438

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 20, 2025

I don't have a strong opinion, but in most cases I think it is better to use what is provided by Ruby org. https://github.com/ruby/debug

This will also fix the following CI failures.

https://github.com/interagent/committee/actions/runs/12712838787/job/35884117256#step:4:14

/home/runner/work/committee/committee/vendor/bundle/ruby/3.5.0+0/gems/pry-0.14.2/lib/pry/command_state.rb:3: warning: ostruct was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
/home/runner/.rubies/ruby-head/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require': cannot load such file -- ostruct (LoadError)
```

I don't have a strong opinion, but in most cases I think it is better to use what is provided by Ruby org.
https://github.com/ruby/debug
Copy link
Member

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@geemus geemus merged commit e1467c6 into master Jan 20, 2025
8 checks passed
@geemus geemus deleted the use-debug branch January 20, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants