Update rack requirement from >= 1.5, < 3.1 to >= 1.5, < 3.2 #431
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rack](https://github.com/rack/rack) to permit the latest version. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@1.5.0...v3.1.7) --- updated-dependencies: - dependency-name: rack dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@ydah - I think the changes here are the right ones to bring this inline with new rack. I also was able to (locally) downgrade back to the old version of rack to confirm that the updated code still has a passing test suite. So I believe this should be good/safe, but I'd appreciate you taking a look as well when you have a moment. Just let me know if you have any questions or I can clarify anyway. Thanks! |
|
Can this change be released to ruby gems? |
|
Yes. I'll try to get a release soon, should probably be able to tomorrow (Monday). |
|
@eric-pigeon Ok, thanks for you patience. This should now be available in v5.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rack to permit the latest version.
Changelog
Sourced from rack's changelog.
... (truncated)
Commits
4bb2f72Bump patch version.1c1e413Ignore external tests directory.b4a1036Prepare for 3.1.7 release.d0da91bAdd more external tests.f6f1510ImproveRack::Responsecontent-length header generation. (#2219)fb339e0Fix encoding setting for non-binary IO-like objects in MockRequest#env_fore21872dDo not remove escaped opening/closing quotes for content-disposition filenames5c3d79fSynchronize changelog with HEAD.bca33b4Allow empty PATH_INFO. (#2214) (#2234)98aa947Bump patch version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)