Dispose of SignalR connections created by HTTP proxy (#329)

* Make compatibility level optional

CompatibilityLevel is deprecated, so make it optional in all AdapterSignalRClient constructors.

* Hub connection should be disposed

Specify that AdapterSignalRClients created by HttpAdapterProxy should dispose of their HubConnections when disposed.

* Update public API

src/DataCore.Adapter.AspNetCore.SignalR.Client/AdapterSignalRClient.cs

@@ -178,7 +178,8 @@ public event Func<Exception, Task> Closed {
         /// <exception cref="ArgumentNullException">
         ///   <paramref name="hubConnection"/> is <see langword="null"/>.
         /// </exception>
-        public AdapterSignalRClient(HubConnection hubConnection, bool disposeConnection, CompatibilityLevel compatibilityLevel) {
+#pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters
+        public AdapterSignalRClient(HubConnection hubConnection, bool disposeConnection, CompatibilityLevel compatibilityLevel = CompatibilityLevel.Latest) {
             _hubConnection = hubConnection ?? throw new ArgumentNullException(nameof(hubConnection));
             _disposeConnection = disposeConnection;
             CompatibilityLevel = compatibilityLevel;
@@ -196,6 +197,7 @@ public AdapterSignalRClient(HubConnection hubConnection, bool disposeConnection,
 
             Closed += OnClosedAsync;
         }
+#pragma warning restore RS0026 // Do not add multiple public overloads with optional parameters
 
 
         /// <summary>

src/DataCore.Adapter.AspNetCore.SignalR.Client/PublicAPI.Shipped.txt

@@ -2,7 +2,6 @@
 const DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.DefaultHubRoute = "/signalr/app-store-connect/v2.0" -> string!
 DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient
 DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.Adapters.get -> DataCore.Adapter.AspNetCore.SignalR.Client.Clients.AdaptersClient!
-DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.AdapterSignalRClient(Microsoft.AspNetCore.SignalR.Client.HubConnection! hubConnection, bool disposeConnection, DataCore.Adapter.AspNetCore.SignalR.Client.CompatibilityLevel compatibilityLevel) -> void
 DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.AdapterSignalRClient(Microsoft.AspNetCore.SignalR.Client.HubConnection! hubConnection, DataCore.Adapter.AspNetCore.SignalR.Client.CompatibilityLevel compatibilityLevel = DataCore.Adapter.AspNetCore.SignalR.Client.CompatibilityLevel.AspNetCore3) -> void
 DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.AssetModel.get -> DataCore.Adapter.AspNetCore.SignalR.Client.Clients.AssetModelBrowserClient!
 DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.Closed -> System.Func<System.Exception!, System.Threading.Tasks.Task!>!

src/DataCore.Adapter.AspNetCore.SignalR.Client/PublicAPI.Unshipped.txt

@@ -1 +1,2 @@
 #nullable enable
+DataCore.Adapter.AspNetCore.SignalR.Client.AdapterSignalRClient.AdapterSignalRClient(Microsoft.AspNetCore.SignalR.Client.HubConnection! hubConnection, bool disposeConnection, DataCore.Adapter.AspNetCore.SignalR.Client.CompatibilityLevel compatibilityLevel = DataCore.Adapter.AspNetCore.SignalR.Client.CompatibilityLevel.AspNetCore3) -> void

src/DataCore.Adapter.Http.Proxy/HttpAdapterProxy.cs

@@ -221,7 +221,7 @@ internal SignalRClientWrapper GetSignalRClient(IAdapterCallContext context) {
             return _signalRClients.GetOrAdd(key, k => {
                 var client = new SignalRClientWrapper(
                     k,
-                    new AspNetCore.SignalR.Client.AdapterSignalRClient(Options.SignalROptions!.ConnectionFactory.Invoke(new Uri(_client.HttpClient.BaseAddress, AspNetCore.SignalR.Client.AdapterSignalRClient.DefaultHubRoute), context)),
+                    new AspNetCore.SignalR.Client.AdapterSignalRClient(Options.SignalROptions!.ConnectionFactory.Invoke(new Uri(_client.HttpClient.BaseAddress, AspNetCore.SignalR.Client.AdapterSignalRClient.DefaultHubRoute), context), true),
                     Options.SignalROptions.TimeToLive <= TimeSpan.Zero
                         ? TimeSpan.FromSeconds(30)
                         : Options.SignalROptions.TimeToLive