Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update run.py #1295

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: update run.py #1295

merged 1 commit into from
Jan 9, 2025

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Jan 6, 2025

Verfication -> Verification


Important

Fix typo in docstring of Validation class in run.py, changing "Verfication" to "Verification".

  • Fix typo in docstring of Validation class in run.py, changing "Verfication" to "Verification".

This description was created by Ellipsis for 3d47dcf. It will automatically update as commits are pushed.

Verfication -> Verification
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3d47dcf in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. examples/citations/run.py:75
  • Draft comment:
    The class name AnswerWithCitaton contains a typo. It should be AnswerWithCitation. This typo appears multiple times in the code (lines 40, 112, 170, 204).
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. examples/citations/run.py:75
  • Draft comment:
    The class name 'AnswerWithCitaton' is misspelled. Consider renaming it to 'AnswerWithCitation'. This issue appears multiple times in the code.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_0fFj3ys6uRPfyviG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jxnl jxnl merged commit a50c279 into instructor-ai:main Jan 9, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants