fix: remove unnecessary type ignore comments

Co-Authored-By: [email protected] <[email protected]>
instructor-ai · Dec 15, 2024 · 87a3876 · 87a3876
1 parent a835030
commit 87a3876
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 9 deletions.
diff --git a/instructor/batch.py b/instructor/batch.py
@@ -1,6 +1,6 @@
 from typing import Any, Union, TypeVar, Optional
 from collections.abc import Iterable
-from pydantic import BaseModel, Field  # type: ignore
+from pydantic import BaseModel, Field
 from instructor.process_response import handle_response_model
 import instructor
 import uuid
@@ -137,7 +137,7 @@ def create_from_messages(
                             "temperature": temperature,
                             "messages": messages,
                             **kwargs,
-                        }
+                        },
                     }
                     file.write(json.dumps(request) + "\n")
         else:

diff --git a/instructor/dsl/citation.py b/instructor/dsl/citation.py
@@ -1,4 +1,4 @@
-from pydantic import BaseModel, Field, model_validator, ValidationInfo  # type: ignore
+from pydantic import BaseModel, Field, model_validator, ValidationInfo
 from collections.abc import Generator
 
 
@@ -57,7 +57,7 @@ class User(BaseModel):
         description="List of unique and specific substrings of the quote that was used to answer the question.",
     )
 
-    @model_validator(mode="after")  # type: ignore[misc]
+    @model_validator(mode="after")
     def validate_sources(self, info: ValidationInfo) -> "CitationMixin":
         """
         For each substring_phrase, find the span of the substring_phrase in the context.

diff --git a/instructor/dsl/iterable.py b/instructor/dsl/iterable.py
@@ -1,7 +1,7 @@
 from typing import Any, Optional, cast, ClassVar
 from collections.abc import AsyncGenerator, Generator, Iterable
 
-from pydantic import BaseModel, Field, create_model  # type: ignore
+from pydantic import BaseModel, Field, create_model
 
 from instructor.function_calls import OpenAISchema
 from instructor.mode import Mode
@@ -109,7 +109,12 @@ def extract_json(
                     }:
                         if json_chunk := chunk.choices[0].delta.content:
                             yield json_chunk
-                    elif mode in {Mode.TOOLS, Mode.TOOLS_STRICT, Mode.FIREWORKS_TOOLS, Mode.WRITER_TOOLS}:
+                    elif mode in {
+                        Mode.TOOLS,
+                        Mode.TOOLS_STRICT,
+                        Mode.FIREWORKS_TOOLS,
+                        Mode.WRITER_TOOLS,
+                    }:
                         if json_chunk := chunk.choices[0].delta.tool_calls:
                             if json_chunk[0].function.arguments is not None:
                                 yield json_chunk[0].function.arguments
@@ -145,7 +150,12 @@ async def extract_json_async(
                     }:
                         if json_chunk := chunk.choices[0].delta.content:
                             yield json_chunk
-                    elif mode in {Mode.TOOLS, Mode.TOOLS_STRICT, Mode.FIREWORKS_TOOLS, Mode.WRITER_TOOLS}:
+                    elif mode in {
+                        Mode.TOOLS,
+                        Mode.TOOLS_STRICT,
+                        Mode.FIREWORKS_TOOLS,
+                        Mode.WRITER_TOOLS,
+                    }:
                         if json_chunk := chunk.choices[0].delta.tool_calls:
                             if json_chunk[0].function.arguments is not None:
                                 yield json_chunk[0].function.arguments

diff --git a/instructor/dsl/maybe.py b/instructor/dsl/maybe.py
@@ -1,4 +1,4 @@
-from pydantic import BaseModel, Field, create_model  # type: ignore
+from pydantic import BaseModel, Field, create_model
 from typing import Generic, Optional, TypeVar
 
 T = TypeVar("T", bound=BaseModel)

diff --git a/instructor/dsl/validators.py b/instructor/dsl/validators.py
@@ -1,7 +1,7 @@
 from typing import Callable, Optional
 
 from openai import OpenAI
-from pydantic import Field  # type: ignore
+from pydantic import Field
 
 from instructor.function_calls import OpenAISchema
 from instructor.client import Instructor