chore: add exit code & tox fix (backport #217) #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
CI/CD
Maxusmusti
force-pushed
the
mergify/bp/release-v0.5/pr-217
branch
from
4c4258e to
38caa4d
Compare
RobotSail
approved these changes
Oct 21, 2024
nathan-weinberg
approved these changes
Oct 21, 2024
Currently, the training library does not exit when an error is encountered within the training loop (invoked through torchrun). This commit updates that functionality so we correctly return an exit code of 1 on child failure. Additionally, this commit also adds the `make fix` command which automatically fixes all trivial issues picked up on by ruff Signed-off-by: Oleg S <[email protected]> (cherry picked from commit 9c899dc)
Maxusmusti
force-pushed
the
mergify/bp/release-v0.5/pr-217
branch
from
38caa4d to
1a57a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the training library does not exit when an error is encountered
within the training loop (invoked through torchrun). This commit updates
that functionality so we correctly return an exit code of 1 on child failure.
Additionally, this commit also adds the
make fixcommand whichautomatically fixes all trivial issues picked up on by ruff
Signed-off-by: Oleg S [email protected]
Resolves #216
This is an automatic backport of pull request #217 done by [Mergify](https://mergify.com).