Added docs.instructlab.ai #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the new mkdocs site for docs.instructlab.ai Signed-off-by: JJ Asghar <[email protected]>
This was referenced Aug 29, 2024
mscherer
requested changes
Aug 30, 2024
| @@ -43,5 +43,11 @@ google._domainkey IN TXT "nWDWqwcNuDNrSiowi1QYQO1V3pcfpCKZCpO | |||
| google._domainkey IN TXT "j7ZQIEZKuZDSyGwogEV7m3SuFNUIMFVoHrdNNGhN+pFjB+P9Cnw30V01k51l7zm3C5HRsa3rQsfg/oc3xBEk9nzvIJVOf3wIDAQAB" | |||
|
|
|||
| qa.ui IN CNAME qa-ui-instructlab-ai-0e3e0ef4c9c6d831e8aa6fe01f33bfc4-0000.us-south.containers.appdomain.cloud. | |||
|
|
|||
|
|
|||
| docs IN A 185.199.108.153 | |||
There was a problem hiding this comment.
So, why use A/AAAA record and not a CNAME ? It seems it would be more future proof in case the underlying IP change (or if Github add a IP).
mscherer
approved these changes
Aug 30, 2024
|
@jjasghar This failed to deploy, as the serial wasn't updated. Sorry, I forgot to check that part as I configured my personal DNS server do that automatically. |
jjasghar
added a commit
to jjasghar/dns-zones
that referenced
this pull request
Aug 30, 2024
Need to bump the serial for the update of the zone. Signed-off-by: JJ Asghar <[email protected]>
jjasghar
added a commit
that referenced
this pull request
Aug 30, 2024
Forgot the serial bump for #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new mkdocs site for docs.instructlab.ai