Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Streams definitely finite or definitely infinite #83

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

jorisdral
Copy link
Collaborator

@jorisdral jorisdral commented Dec 9, 2024

No description provided.

@jorisdral jorisdral self-assigned this Dec 9, 2024
@jorisdral jorisdral force-pushed the jdral/infinite-stream branch from 44cc1ad to f93ed8c Compare December 9, 2024 22:22
@jorisdral jorisdral changed the base branch from main to jdral/fix-errors-shrink December 9, 2024 22:23
Base automatically changed from jdral/fix-errors-shrink to main December 10, 2024 14:23
@jorisdral jorisdral force-pushed the jdral/infinite-stream branch 2 times, most recently from 8882b03 to c3fc9d9 Compare December 18, 2024 16:20
@jorisdral jorisdral force-pushed the jdral/infinite-stream branch from c3fc9d9 to d5dc596 Compare December 30, 2024 11:35
@jorisdral jorisdral marked this pull request as ready for review December 30, 2024 11:35
@jorisdral jorisdral requested a review from a team as a code owner December 30, 2024 11:35
Where streams could previously be *definitely* finite or *possibly* infinite,
they should now be *definitely* finite or *definitely* infinite. This is mostly
a conceptual change: it was already guaranteed by most if not all of the
`Stream` functions. Still, the conceptual change should make the use of
`Streams` more ergonomic going forward.

As a result of and in addition to the conceptual change, the `Stream`
interface got an overhaul. The concrete changes are listed in the changelog.

Finally, we add a bunch of tests for the `Stream` module.
@jorisdral jorisdral force-pushed the jdral/infinite-stream branch from d5dc596 to d776abb Compare December 30, 2024 11:49
@jorisdral jorisdral enabled auto-merge December 30, 2024 11:50
@jorisdral jorisdral added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 22ca7c9 Dec 30, 2024
22 checks passed
@jorisdral jorisdral deleted the jdral/infinite-stream branch December 30, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants