This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
79 integrate consensus with trivial ledger #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
reviewed
Feb 17, 2020
oddchain/src/Oddchain.hs
Outdated
Comment on lines
721
to
723
| !theSignedPart <- fromCBOR | ||
| !theSignature <- fromCBOR | ||
| pure $! OddHeader |
There was a problem hiding this comment.
If you have bangs on the field of OddHeader, do you still need the bangs here and $!? I'm assuming the result of the Decoder is evaluated to WHNF.
There was a problem hiding this comment.
No. It's just the habit.
dnadales
force-pushed
the
79-integrate-consensus-with-trivial-ledger
branch
from
c98022d to
d134e76
Compare
The README describes the demo.
dnadales
force-pushed
the
79-integrate-consensus-with-trivial-ledger
branch
from
d134e76 to
c7cebdb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.