Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tanstack Start handler #792

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

djfarrelly
Copy link
Member

@djfarrelly djfarrelly commented Jan 3, 2025

Summary

New handler for the Tanstack Start framework.

Notes

Since the framework expects handles for each GET, POST, PUT, the serve handler doesn't expose a default handler which doesn't work with the test framework. I'd love some input from @jpwilliams on a good approach there.

Folks in our community have recommended using the h3 handler instead - we may want to shift to use that instead of emulating the edge handler: https://discord.com/channels/842170679536517141/1324205318690832446/1326578673498718319

Checklist

  • Added a docs PR that references this PR
  • Added unit/integration tests
  • Added changesets if applicable

Related

  • INN-

Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: e85500c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Jan 3, 2025
@djfarrelly djfarrelly changed the title Add Tanstack SStart handler Add Tanstack Start handler Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants