Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to build all packages before shipping #444

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Jan 2, 2024

Summary

Some packages were not being built properly before shipping if multiple packages were shipped at the same time.

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests N/A
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the 💡 KTLO Chores, dependency updates, and routine tasks label Jan 2, 2024
@jpwilliams jpwilliams requested a review from IGassmann January 2, 2024 15:58
@jpwilliams jpwilliams self-assigned this Jan 2, 2024
Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: b88ce00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@inngest/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams enabled auto-merge (squash) January 2, 2024 16:01
@jpwilliams jpwilliams merged commit 6597215 into main Jan 2, 2024
33 checks passed
@jpwilliams jpwilliams deleted the ktlo/release-builds branch January 2, 2024 16:03
jpwilliams pushed a commit that referenced this pull request Jan 2, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @inngest/[email protected]

### Patch Changes

- [#444](#444)
[`6597215`](6597215)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix packages
sometimes not shipping dist files if released with multiple packages

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jpwilliams added a commit that referenced this pull request Jan 2, 2024
## Summary
<!-- Succinctly describe your change, providing context, what you've
changed, and why. -->

A follow-up to #444 - we run the wrong script when releasing 🙄

## Checklist
<!-- Tick these items off as you progress. -->
<!-- If an item isn't applicable, ideally please strikeout the item by
wrapping it in "~~"" and suffix it with "N/A My reason for skipping
this." -->
<!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" -->

- [ ] ~~Added a [docs PR](https://github.com/inngest/website) that
references this PR~~ N/A
- [ ] ~~Added unit/integration tests~~ N/A
- [x] Added changesets if applicable

## Related
<!-- A space for any related links, issues, or PRs. -->
<!-- Linear issues are autolinked. -->
<!-- e.g. - INN-123 -->
<!-- GitHub issues/PRs can be linked using shorthand. -->
<!-- e.g. "- inngest/inngest#123" -->
<!-- Feel free to remove this section if there are no applicable related
links.-->
- #444
jpwilliams pushed a commit that referenced this pull request Jan 4, 2024
…g dist folder (#451)

## Summary
`"Some packages were not being built properly before shipping if
multiple packages were shipped at the same time."` -
/issues/444

That has since been fixed by /issues/444, but
`@inngest/middleware-encryption` still needs to be re-released so dist
files are published.




## Checklist
<!-- Tick these items off as you progress. -->
<!-- If an item isn't applicable, ideally please strikeout the item by
wrapping it in "~~"" and suffix it with "N/A My reason for skipping
this." -->
<!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" -->

- [ ] ~~Added a [docs PR](https://github.com/inngest/website) that
references this PR~~
- [ ] ~~Added unit/integration tests~~
- [x] Added changesets if applicable

## Related
<!-- A space for any related links, issues, or PRs. -->
<!-- Linear issues are autolinked. -->
<!-- e.g. - INN-123 -->
<!-- GitHub issues/PRs can be linked using shorthand. -->
<!-- e.g. "- inngest/inngest#123" -->
<!-- Feel free to remove this section if there are no applicable related
links.-->
- Related to /issues/444
- Fixes /issues/450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 KTLO Chores, dependency updates, and routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @inngest/eslint-plugin missing dist
2 participants