Don't return a Response in inngest/next if in serverless
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the type, though.
🦋 Changeset detectedLatest commit: 94bd507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
djfarrelly
approved these changes
Dec 12, 2023
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Dec 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#421](#421) [`471d11f`](471d11f) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix serverless use of `inngest/next` with `next@>=13.0.0 <13.5.0` failing to return a response, as well as `next@>=13.5.0` logging the same error ## @inngest/[email protected] ### Patch Changes - [#419](#419) [`4de1605`](4de1605) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add the encryption method used (`AES-256-CBC`) by default to the README Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Next.js versions
next@>=13.0.0 <13.5.0will throw an error if aResponseobject is returned from a serverless endpoint.next@>=13.5.0will display the error but continue to function.Next.js edge still requires that the
ReturnTypeof the function is aResponse, so we keep that type whilst ensuring it's not actually passed back in serverless endpoints.There are so many edge cases here and this one breaks across minor versions. Separate exports (e.g.
inngest/next-13-edge) might be appropriate in the future if the type/runtime guards continue to become stricter on the Next.js side.Checklist
Added a docs PR that references this PRN/A Bug fixAdded unit/integration testsN/A Will observe logs disappearing in current integration tests which use[email protected]: https://github.com/inngest/inngest-js/actions/runs/7181668471/job/19556571083?pr=421Related
req.url#400