Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasEventKey in GET request always returning true #395

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Nov 13, 2023

Summary

Fixes the hasEventKey property in GET requests to a serve handler always returning true.

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests N/A
  • Added changesets if applicable

@jpwilliams jpwilliams added the Bug Something isn't working label Nov 13, 2023
@jpwilliams jpwilliams self-assigned this Nov 13, 2023
Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 81497c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams merged commit aebc2c4 into main Nov 14, 2023
25 checks passed
@jpwilliams jpwilliams deleted the fix/haseventkey-fake branch November 14, 2023 16:05
jpwilliams pushed a commit that referenced this pull request Nov 17, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @inngest/[email protected]

### Patch Changes

- [#377](#377)
[`996e3b7`](996e3b7)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Release
`@inngest/eslint-plugin` package to help capture common gotchas

## [email protected]

### Patch Changes

- [#401](#401)
[`c77f6d7`](c77f6d7)
Thanks [@tonyhb](https://github.com/tonyhb)! - Remove "Step already
exists; automatically indexing" log

- [#395](#395)
[`aebc2c4`](aebc2c4)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix `hasEventKey`
in `GET` request always returning `true`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant