Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dummy value for event key for local development #361

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jpwilliams
Copy link
Member

Summary

This fixes a bug whereby events are attempted to send to /e instead of /e/123, resulting in failed requests following #357.

We should maintain that the API should always expect a key, so we'll make the change here to set a dummy key just as users had to pre-#357.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

Related

This fixes a bug whereby events are attempted to send to /e instead of
/e/123, resulting in failed requests following #357.
@jpwilliams jpwilliams added the Bug Something isn't working label Oct 13, 2023
@jpwilliams jpwilliams self-assigned this Oct 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

⚠️ No Changeset found

Latest commit: 6f41e6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tonyhb tonyhb merged commit dcce758 into main Oct 16, 2023
@tonyhb tonyhb deleted the fix/event-sending-dev-key branch October 16, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants