Merge branch 'main' into fix/next-js-13-host

inngest · Nov 22, 2023 · 6d867ca · 6d867ca
2 parents 158ff30 + be5544b
commit 6d867ca
Show file tree

Hide file tree

Showing 29 changed files with 1,293 additions and 534 deletions.
diff --git a/.changeset/wicked-beans-heal.md b/.changeset/wicked-beans-heal.md
@@ -0,0 +1,5 @@
+---
+"inngest": patch
+---
+
+Fix correctness issues in generated `*.d.ts` files, causing errors for some versions/configurations of TypeScript with `skipLibCheck: false`
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -50,6 +50,7 @@ jobs:
       matrix:
         tsVersion:
          - 'latest'
+         - '~5.3.0'
          - '~5.2.0'
          - '~5.1.0'
          - '~5.0.0'
@@ -61,6 +62,7 @@ jobs:
       - uses: ./.github/actions/setup-and-build
       - run: pnpm add -D typescript@${{ matrix.tsVersion }}
       - run: pnpm run test:types
+      - run: pnpm run test:dist
 
   inngest_api_diff:
     name: "inngest: Local API diff"
@@ -84,6 +86,28 @@ jobs:
       - uses: ./.github/actions/setup-and-build
       - run: pnpm run lint
 
+  inngest_test_dist:
+    name: "inngest: Dist tests"
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: packages/inngest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/actions/setup-and-build
+      - run: pnpm run test:dist
+
+  inngest_test_deps:
+    name: "inngest: Dependency tests"
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: packages/inngest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ./.github/actions/setup-and-build
+      - run: pnpm run test:deps
+
   "eslint-plugin_test":
     name: "eslint-plugin: Test"
     runs-on: ubuntu-latest

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -31,7 +31,7 @@
   "license": "ISC",
   "dependencies": {
     "@typescript-eslint/utils": "^6.11.0",
-    "typescript": "^5.2.2"
+    "typescript": "~5.3.0"
   },
   "devDependencies": {
     "@typescript-eslint/rule-tester": "^6.11.0",

diff --git a/packages/inngest/.eslintrc.js b/packages/inngest/.eslintrc.js
@@ -27,6 +27,31 @@ module.exports = {
     ],
     "import/consistent-type-specifier-style": ["error", "prefer-inline"],
     "import/no-duplicates": ["error", { "prefer-inline": true }],
+    "import/no-extraneous-dependencies": [
+      "error",
+      {
+        devDependencies: [
+          "**/*.test.ts",
+          "**/test/**",
+          "**/scripts/**",
+          "src/cloudflare.ts",
+          "src/digitalocean.ts",
+          "src/edge.ts",
+          "src/express.ts",
+          "src/fastify.ts",
+          "src/h3.ts",
+          "src/koa.ts",
+          "src/lambda.ts",
+          "src/next.ts",
+          "src/nuxt.ts",
+          "src/redwood.ts",
+          "src/remix.ts",
+          "src/sveltekit.ts",
+        ],
+        includeInternal: true,
+        includeTypes: true,
+      },
+    ],
   },
   overrides: [
     {

diff --git a/packages/inngest/etc/inngest.api.md b/packages/inngest/etc/inngest.api.md
diff --git a/packages/inngest/package.json b/packages/inngest/package.json
@@ -15,6 +15,8 @@
     "itest": "tsx scripts/integrationTestRunner.ts",
     "test:examples": "jest --logHeapUsage --maxWorkers=8 --testMatch \"**/test/functions/**/*.test.ts\" --ci --verbose",
     "test:types": "tsc --noEmit --project tsconfig.types.json --listFiles",
+    "test:dist": "tsc --noEmit dist/**/*.d.ts",
+    "test:deps": "tsx scripts/checkDependencies.ts",
     "clean": "rm -rf ./dist",
     "lint": "eslint .",
     "postversion": "pnpm run build && pnpm run build:copy",
@@ -127,7 +129,7 @@
     "trailingComma": "es5"
   },
   "dependencies": {
-    "buffer": "^6.0.3",
+    "@types/debug": "^4.1.12",
     "canonicalize": "^1.0.8",
     "chalk": "^4.1.2",
     "cross-fetch": "^4.0.0",
@@ -139,6 +141,7 @@
     "serialize-error-cjs": "^0.1.3",
     "strip-ansi": "^5.2.0",
     "type-fest": "^3.13.1",
+    "type-plus": "^5.1.0",
     "zod": "~3.22.3"
   },
   "devDependencies": {
@@ -151,7 +154,6 @@
     "@sveltejs/kit": "^1.27.3",
     "@total-typescript/shoehorn": "^0.1.1",
     "@types/aws-lambda": "^8.10.108",
-    "@types/debug": "^4.1.8",
     "@types/express": "^4.17.13",
     "@types/inquirer": "^9.0.3",
     "@types/jest": "^27.4.1",
@@ -161,17 +163,18 @@
     "@types/ms": "^0.7.31",
     "@types/node": "^18.16.16",
     "@types/sha.js": "^2.4.0",
-    "@typescript-eslint/eslint-plugin": "^5.47.0",
-    "@typescript-eslint/parser": "^5.47.0",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
     "@vercel/node": "^2.15.9",
     "concurrently": "^7.4.0",
     "eslint": "^8.30.0",
-    "eslint-config-prettier": "^8.5.0",
+    "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-prettier": "^5.0.0",
     "express": "^4.18.2",
     "fastify": "^4.21.0",
     "genversion": "^3.1.1",
+    "glob": "^10.3.10",
     "inquirer": "^9.2.10",
     "jest": "^29.3.1",
     "koa": "^2.14.2",
@@ -180,12 +183,11 @@
     "nock": "^13.2.9",
     "node-mocks-http": "^1.11.0",
     "nodemon": "^2.0.20",
-    "prettier": "^2.7.1",
+    "prettier": "^3.1.0",
     "shx": "^0.3.4",
     "ts-jest": "^29.1.0",
     "tsx": "^3.12.7",
-    "type-plus": "^5.1.0",
-    "typescript": "^5.2.2",
+    "typescript": "~5.3.0",
     "ulid": "^2.3.0"
   },
   "volta": {