Add CI, various minor comment changes

.github/workflows/go.yaml

@@ -0,0 +1,37 @@
+name: Go
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+
+jobs:
+  golangci:
+    name: lint
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '1.21'
+      - name: Lint
+        run: |
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.55.1
+          ./bin/golangci-lint run --verbose
+  test-linux-race:
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '1.21'
+      - name: Test
+        run: go test ./... -v -count=1

expr.go

@@ -32,6 +32,8 @@ type AggregateEvaluator interface {
 	Remove(ctx context.Context, eval Evaluable) error
 
 	// AggregateMatch returns all expression parts which are evaluable given the input data.
+	//
+	// It does this by iterating through the data,
 	AggregateMatch(ctx context.Context, data map[string]any) ([]ExpressionPart, error)
 
 	// Evaluate checks input data against all exrpesssions in the aggregate in an optimal
@@ -166,6 +168,10 @@ func (a *aggregator) AggregateMatch(ctx context.Context, data map[string]any) ([
 }
 
 func (a *aggregator) aggregateMatch(ctx context.Context, data map[string]any, prefix string) ([]ExpressionPart, error) {
+	// TODO: Flip this.  Instead of iterating through all fields in a potentially large input
+	// array, iterate through all known variables/idents in the aggregate tree to see if
+	// the data has those keys set.
+
 	result := []ExpressionPart{}
 	for k, v := range data {
 		switch cast := v.(type) {

expr_test.go

@@ -40,6 +40,7 @@ func evaluate(b *testing.B, i int, parser TreeParser) error {
 	// Insert N random matches.
 	for n := 0; n < i; n++ {
 		wg.Add(1)
+		//nolint:all
 		go func() {
 			defer wg.Done()
 			byt := make([]byte, 8)
@@ -78,11 +79,12 @@ func TestEvaluate(t *testing.T) {
 	_, err = e.Add(ctx, expected)
 	require.NoError(t, err)
 
-	n := 1_000
+	n := 100_000
 
 	wg := sync.WaitGroup{}
 	for i := 0; i < n; i++ {
 		wg.Add(1)
+		//nolint:all
 		go func() {
 			defer wg.Done()
 			byt := make([]byte, 8)
@@ -108,7 +110,7 @@ func TestEvaluate(t *testing.T) {
 				},
 			},
 		})
-		total := time.Now().Sub(pre)
+		total := time.Since(pre)
 		fmt.Printf("Matched in %v ns\n", total.Nanoseconds())
 		fmt.Printf("Matched in %v ms\n", total.Milliseconds())
 
@@ -128,7 +130,7 @@ func TestEvaluate(t *testing.T) {
 				},
 			},
 		})
-		total := time.Now().Sub(pre)
+		total := time.Since(pre)
 		fmt.Printf("Matched in %v ns\n", total.Nanoseconds())
 		fmt.Printf("Matched in %v ms\n", total.Milliseconds())
 

groupid.go

@@ -1,8 +1,8 @@
 package expr
 
 import (
+	"crypto/rand"
 	"encoding/binary"
-	"math/rand"
 )
 
 // groupID represents a group ID.  The first 2 byets are an int16 size of the expression group,
@@ -15,7 +15,7 @@ func (g groupID) Size() uint16 {
 }
 
 func newGroupID(size uint16) groupID {
-	id := make([]byte, 8, 8)
+	id := make([]byte, 8)
 	binary.NativeEndian.PutUint16(id, size)
 	_, _ = rand.Read(id[2:])
 	return [8]byte(id[0:8])

parser.go

@@ -2,7 +2,6 @@ package expr
 
 import (
 	"context"
-	"crypto/md5"
 	"fmt"
 	"strconv"
 	"strings"
@@ -270,12 +269,14 @@ type Predicate struct {
 	// variable are being compared, this is nil and LiteralIdent holds a pointer to the
 	// name of the second variable.
 	Literal any
+
+	// Ident is the ident we're comparing to, eg. the variable.
+	Ident string
+
 	// LiteralIdent represents the second literal that we're comparing against,
 	// eg. in the expression "event.data.a == event.data.b this stores event.data.b
 	LiteralIdent *string
 
-	// Ident is the ident we're comparing to, eg. the variable.
-	Ident string
 	// Operator is the binary operator being used.  NOTE:  This always assumes that the
 	// ident is to the left of the operator, eg "event.data.value > 100".  If the value
 	// is to the left of the operator, the operator will be switched
@@ -297,11 +298,6 @@ func (p Predicate) String() string {
 	}
 }
 
-func (p Predicate) hash() string {
-	sum := md5.Sum([]byte(fmt.Sprintf("%v", p)))
-	return string(sum[:])
-}
-
 func (p Predicate) LiteralAsString() string {
 	str, _ := p.Literal.(string)
 	return str

parser_test.go

@@ -10,12 +10,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func newTestAggregateEvaluator(t *testing.T) AggregateEvaluator {
-	t.Helper()
-	parser, _ := newParser()
-	return NewAggregateEvaluator(parser, testBoolEvaluator)
-}
-
 func newEnv() *cel.Env {
 	env, _ := cel.NewEnv(
 		cel.Variable("event", cel.AnyType),